Skip to content

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Manual backport of #2884, fixes some cmd test failures.

Summary

Sets IGN_IP=127.0.0.1 to workaround networking issues in some CI machines. Fixes ModelCommandAPI tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Manual backport of #2884.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 25, 2025
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jun 25, 2025
@scpeters scpeters marked this pull request as ready for review June 26, 2025 06:50
@scpeters scpeters requested a review from mjcarroll as a code owner June 26, 2025 06:50
@scpeters scpeters merged commit 5e31757 into ign-gazebo6 Jun 26, 2025
10 of 11 checks passed
@scpeters scpeters deleted the scpeters/fortress_set_ign_ip branch June 26, 2025 06:51
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants